-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ruby 2.3.0 & 2.4.1 testing, remove Ruby 1.9.3 & 2.0 testing #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -26,8 +26,8 @@ deploy: | |||
on: | |||
tags: true | |||
all_branches: true | |||
rvm: 1.9.3 | |||
rvm: 2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with this as it is an EOL version, I would just like to know what failed that made you want to remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see it was already removed in gemspec: e14928c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing failed, however the required Ruby version in the gemspec for this plugin has already been bumped to 2.1.0 previously so I thought there was little point testing against 2.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You beat me replying :)
This plugin was also lacking love, I tried to tag old releases not previously tagged and added changelog messages (probably not accurate enough but did not want to spend too much time given that we should never have this again). |
Pull Request Checklist
sensu-plugins/community#27
General
Update Changelog following the conventions laid out on Keep A Changelog
RuboCop passes
Existing tests pass
Purpose