Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hostname in output #130

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

fix hostname in output #130

wants to merge 9 commits into from

Conversation

bmx0r
Copy link

@bmx0r bmx0r commented May 27, 2020

Pull Request Checklist

Is this in reference to an existing issue?
no

General

  • Update Changelog following the conventions laid out here

  • Update README with any necessary configuration snippets

  • Binstubs are created if needed

  • RuboCop passes

  • Existing tests pass

New Plugins

  • Tests

  • Add the plugin to the README

  • Does it have a complete header as outlined here

Purpose

  • When using the script with -h 127.0.0.1 we end up with 127 as hostname, I change to have a hostname more graphite compliant
  • include MR Collect more innodb variables #111: Collect more innodb variables Collect more innodb variables #111
  • include metrics gathering from https://github.com/sensu-plugins/sensu-plugins-percona in metrics-mysql-graphite.rb (there is no reason to run the gathering twice and no reasons to keep two code base)

Known Compatibility Issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants