-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Ruby 1.9.3 support, add Ruby 2.3.0 & 2.4.1 tests #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just one minor nitpick.
CHANGELOG.md
Outdated
@@ -1,3 +1,15 @@ | |||
#Change Log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put a space between #
and Changelog
so its a header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops. Well spotted 👍
travis is taking a while if I don't circle back to this in 24 hours ping me. https://travis-ci.org/sensu-plugins/sensu-plugins-rethinkdb/builds/253972113 |
canceled and restarted job, looks good now. |
this plugin has had no love in a while, nothing was tagged. I did some cleanup and at least tagged the version deployed to rubygems.org |
looks like we dont have access to that gem, will ping the owner. |
looks like we have tried #2 |
Pull Request Checklist
sensu-plugins/community#27
General
Update Changelog following the conventions laid out on Keep A Changelog
RuboCop passes
Existing tests pass
Purpose
Known Compatablity Issues