Drop Ruby 1.9.3 support, add Ruby 2.3.0 & 2.4.1 tests #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majormoses
requested changes
Jul 15, 2017
CHANGELOG.md
Outdated
| @@ -1,3 +1,15 @@ | |||
| #Change Log | |||
There was a problem hiding this comment.
put a space between # and Changelog so its a header.
There was a problem hiding this comment.
Whoops. Well spotted 👍
majormoses
approved these changes
Jul 15, 2017
|
travis is taking a while if I don't circle back to this in 24 hours ping me. https://travis-ci.org/sensu-plugins/sensu-plugins-rethinkdb/builds/253972113 |
|
canceled and restarted job, looks good now. |
|
this plugin has had no love in a while, nothing was tagged. I did some cleanup and at least tagged the version deployed to rubygems.org |
|
looks like we dont have access to that gem, will ping the owner. |
|
looks like we have tried #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
sensu-plugins/community#27
General
Update Changelog following the conventions laid out on Keep A Changelog
RuboCop passes
Existing tests pass
Purpose
Known Compatablity Issues