Ruby 2.4 support #29
Merged
Ruby 2.4 support #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majormoses
requested changes
Jul 3, 2017
There was a problem hiding this comment.
@Evesy thank you so much for helping, let's just change the verbiage to testing rather than supporting it. Before declaring that we need to do functional runtime testing on it.
CHANGELOG.md
Outdated
| @@ -4,6 +4,8 @@ This project adheres to [Semantic Versioning](http://semver.org/). | |||
| This CHANGELOG follows the format listed at [Keep A Changelog](http://keepachangelog.com/) | |||
|
|
|||
| ## [Unreleased] | |||
| ### Added | |||
| - Ruby 2.4 support | |||
There was a problem hiding this comment.
testing not support. It's just testing install time changes, we are gonna have to also test runtime changes before saying we officially support 2.4.
majormoses
approved these changes
Jul 3, 2017
|
@Evesy thank you for helping with this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
RE sensu-plugins/community#27
General
Update Changelog following the conventions laid out on Keep A Changelog
RuboCop passes
Existing tests pass
Purpose
Ruby 2.4 support
Known Compatablity Issues