Fix for failing repo on Amazon Linux #821

Use repository for rhel 6 on Amazon linux
Experimental retrospec generated tests for sensu::repo classes
Refactored tests for sensu::repo::yum

manifests/repo/yum.pp

@@ -8,9 +8,13 @@
     if $::sensu::repo_source {
       $url = $::sensu::repo_source
     } else {
+      $releasever = $::operatingsystem ? {
+        'Amazon' => '6',
+        default  => '$releasever',
+      }
       $url = $::sensu::repo ? {
-        'unstable'  => "https://sensu.global.ssl.fastly.net/yum-unstable/\$releasever/\$basearch/",
-        default     => "https://sensu.global.ssl.fastly.net/yum/\$releasever/\$basearch/"
+        'unstable'  => "https://sensu.global.ssl.fastly.net/yum-unstable/${releasever}/\$basearch/",
+        default     => "https://sensu.global.ssl.fastly.net/yum/${releasever}/\$basearch/"
       }
     }
 

metadata.json

@@ -46,6 +46,12 @@
         "14.04",
         "16.04"
       ]
+    },
+    {
+      "operatingsystem": "Amazon",
+      "operatingsystemrelease": [
+        "2017.03"
+      ]
     }
   ],
   "requirements": [

spec/classes/repo/yum_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+
+describe 'sensu::repo::yum' do
+
+  context 'on RedHat derivatives' do
+    let(:facts) do
+      { :osfamily => 'RedHat' }
+    end      
+    is_expected.to contain_yumrepo('sensu').with( {
+      'enabled'  => '1',
+      'baseurl'  => 'https://sensu.global.ssl.fastly.net/yum/$releasever/$basearch/',
+      'gpgcheck' => '0',
+      'name'     => 'sensu',
+      'descr'    => 'sensu',
+      'before'   => 'Package[sensu]',
+    })
+  end
+
+  context 'on Amazon Linux' do
+    let(:facts) do
+      { :operatingsystem => 'Amazon' }
+    end
+    is_expected.to contain_yumrepo('sensu').with( {
+      'enabled'  => '1',
+      'baseurl'  => 'https://sensu.global.ssl.fastly.net/yum/6/$basearch/',
+      'gpgcheck' => '0',
+      'name'     => 'sensu',
+      'descr'    => 'sensu',
+      'before'   => 'Package[sensu]',
+    })
+  end
+
+end