Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert sensu_sorted_json legacy function to new Ruby function #1056

Merged
merged 3 commits into from
Jan 27, 2019

Conversation

treydock
Copy link
Collaborator

@treydock treydock commented Jan 25, 2019

Pull Request Checklist

Description

Convert sensu_sorted_json that was Legacy Puppet 3 format to new Ruby function format introduced in Puppet 4.

Related Issue

Fixes #1055

Motivation and Context

This should fix issue raised in #1055 where Puppet 6.2.0 does not allow legacy function to define Ruby functions.

How Has This Been Tested?

Ran vagrant up sensu-server --provision on existing Vagrant VM and no changes took place.

@treydock treydock force-pushed the sorted_json branch 2 times, most recently from c3daaa1 to 2c5cfde Compare January 26, 2019 00:03
@treydock
Copy link
Collaborator Author

For sake of backwards compatibility I kept the function name the same, sensu_sorted_json.

@treydock treydock changed the title Convert sensu_sorted_json legacy function to sensu::sorted_json Ruby function Convert sensu_sorted_json legacy function to new Ruby function Jan 26, 2019
@treydock
Copy link
Collaborator Author

Updated acceptance tests to include handler and check from manifests used with Vagrant. The primary purpose is to programmatically stress sensu_sorted_json during the acceptance tests since we are installing some tests with latest Puppet 6 .

@ghoneycutt ghoneycutt merged commit 6e87610 into sensu:master Jan 27, 2019
@treydock treydock deleted the sorted_json branch January 28, 2019 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Illegal method definition of method 'validate_keys' on line 8' in legacy function.
2 participants