Several fixes #106
Merged
Several fixes #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LarsFronius
commented
Sep 24, 2013
LarsFronius
commented
- Avoid settings whitespaces by rewriting whitespace to underscore, since it is forbidden in sensu anyway.
- I ran into /etc/sensu/conf.d directory does not exist several times for initial setup, so I require package installation for this directory
- setting subscriber and handler for checks should be optional
- if handler is an empty array, the server won't process with default handler
- I don't want to set the handler for all my puppet defined checks, so if I leave it empty, I want to use default handling on server.
$releasever results in "6Server" on RHEL 6.4.
This reverts commit 52ad15e.
- empty array for check-handler avoids sensu-server to use default handler - I don't want to set default handler on all puppet checks
|
Hey @LarsFronius! Thanks for this - awesome stuff. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.