Added sensu::manage_services to optionally disable internal service management. #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi - thanks for your contribution! Can you review the test failures please and fix? Thanks! 👍 |
|
Alright, fixed that. I'm still rather new to Puppet and definitely not a Ruby developer.. so I apologize for pushing shotty code. I was not able to get rspec-puppet working on my windows machine, or dev vm (Vagrant/CentOS 6.4) so I had to take a shot in the dark. If you know of any articles that might point me in the right direction on how to get setup for puppet testing I would appreciate it. |
jamtur01
added a commit
that referenced
this pull request
Dec 1, 2013
Added sensu::manage_services to optionally disable internal service management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an extra variable to the sensu class, $manage_services (bool, default=true). When set to FALSE the module will not attempt to create or modify services.
This feature will allow external service management, as with DaemonTools and SupervisorD.