Added direct support for timeout,aggregate,handle,publish,occurrences and refresh parameters to sensu_check

[zdenekjanda]

As suggested on IRC. timeout/aggregate/handle/publish are used by sensu server, and occurrences/refresh by sensu handler, so its logical to have them usable directly. you can still feed them with custom param too, so should be backwards compatible.

[jamtur01]

Be good to update any examples in the README

@jlambert121 Your thoughts?

[jlambert121]

I think these were once first class parameters and they were pulled out and moved to the custom parameter because they weren't native sensu parameters but stuff added by the client libraries. Is my memory faulty on that one?

[jamtur01]

It rings a bell. There's a PR for it somewhere I think. Or discussion in the custom params PR perhaps?

[jlambert121]

I can do some more digging this afternoon MT to see what's in the sensu core unless there is a complete list somewhere we can just implement. I think doing everything in core as a parameter would be reasonable.

[zdenekjanda]

so, to put more light in, timeout/aggregate/handle/publish are used in server core. occurrences/refresh is used by sensu-handler, which is direcly invoked by core. sensu-chef indeed does have timeout/aggregate/handle/publish directly within sensu_check, but it doesnt have occurrences/refresh. i am still convinced that we can add occurrences/refresh directly into sensu_check, because they will be always sent by server to sensu-handler and are used very often. Rest of parameters, for customization, makes sense to pass as hash in sensu_check.custom.

[zdenekjanda]

There is a lot discussion on it, for ex. here: #75, here: #97, latest check.rb from sensu-chef by @portertech: https://github.com/sensu/sensu-chef/blob/master/resources/check.rb
I guess we dont have to discuss about timeout/aggregate/handle/publish, they should be definivelly here, but occurrences/refresh is the challenge. These two have been repetitively added and again removed to this module, i still do vote to have them in to enable typing of data and due to fact that sensu-handler is defacto part of core, but perhaps @portertech can enlight us :)

[jlambert121]

I agree on timeout/aggregate/handle/publish - they are in sensu "core" and should be first class citizens here. I also like the parity with the chef cookbook.

I know I have a bunch of 'custom => { occurrences => 2, refresh => 60 }' in my manifests. The last time refresh was mentioned (#97) portertech chimed in and voted against. I see refresh and occurrences used by the ruby sensu-plugin but not the python sensu-plugin-python so those aren't even ubiquitous at this point with the official plugin libraries.

I'm in favor of drawing the line of native attributes to those that are implemented by sensu core. It keeps it consistent and in parity with the chef cookbook since it looks like that is the implementation there.

[jamtur01]

+1

[portertech]

+1

[jlambert121]

@zdenekjanda could you squash these 5 commits into one and I'll merge this? We're about to release 1.0.0 and this is a great addition - thanks!