Fix sensu dashboard config type conversion to always be a string #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that when puppet queries the provider for "user" and "password", when they are not there in the json they are "null". This manifests itself on the terminal as an empty string though, so it is not obvious why it doesn't converge:
However, when you ask the parameters to be "" like:
The provider removes the user and password entries in the json as requested, but the catalog never converges because null != '', and never will.
This change fixes this by making the type conversion happen in the provider, allowing the catalog to converge by "faking" the value as an empty string just like we kinda fake the setting of it by removing it out of the json.
I don't know really how to test for this without serverspec stuff and testing for convergence?