plugin: Rewrite the logic of define_plugins_dir #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there is a duplicate error duplication when compiling the catalog. This is due to the fact that the call to `define_plugins_dir` is called with the exact same parameter `$install_path` hence causing the error. By including the name of the plugin within the name of the resource we ensure the resource name is unique during catalog compilation.
|
LGTM |
jamtur01
added a commit
that referenced
this pull request
Sep 25, 2014
plugin: Rewrite the logic of define_plugins_dir
|
Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is a duplicate error duplication when
compiling the catalog. This is due to the fact that the
call to
define_plugins_diris called with the exact sameparameter
$install_pathhence causing the error.By including the name of the plugin within the name of the resource
we ensure the resource name is unique during catalog compilation.