Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow modification of hasrestart attribute for services #359

Merged
merged 1 commit into from
Jun 10, 2015

Conversation

somic
Copy link
Contributor

@somic somic commented Jun 8, 2015

At my company we ship our own startup scripts that use upstart. When those scripts change, in order for upstart to pick up the changes, a job needs to be stopped and then started (see http://upstart.ubuntu.com/faq.html#reload).

With hasrestart hard coded to true, it's not possible. This change allows us to control hasrestart attribute.

This change is fully backwards compatible - by default value of hasrestart everywhere is true.

@jlambert121
Copy link
Contributor

Could you add a test to make sure true is set on hasrestart as the default? (Will help raise a flag if the default changes)

@somic
Copy link
Contributor Author

somic commented Jun 10, 2015

@jlambert121
Copy link
Contributor

You are absolutely right, my apologies.

jlambert121 added a commit that referenced this pull request Jun 10, 2015
allow modification of hasrestart attribute for services
@jlambert121 jlambert121 merged commit cf40de6 into sensu:master Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants