Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install rake < 11.0.0 for ruby < 1.9.3 #487

Merged
merged 1 commit into from
Mar 16, 2016
Merged

Install rake < 11.0.0 for ruby < 1.9.3 #487

merged 1 commit into from
Mar 16, 2016

Conversation

atrepca
Copy link
Contributor

@atrepca atrepca commented Mar 12, 2016

Starting with version 11.0.0 rake requires ruby 1.9.3 or later, see ruby/rake@4ab6eba. This is causing Travis tests to fail, see the Ruby: 1.8.7 builds for #486:

Gem::InstallError: rake requires Ruby version >= 1.9.3.
An error occurred while installing rake (11.0.1), and Bundler cannot continue.

@atrepca atrepca changed the title Install rake < 11 for ruby < 1.9 Install rake < 11.0.0 for ruby < 1.9.3 Mar 12, 2016
@jlambert121
Copy link
Contributor

I think rake 11.0 breaks when beaker is installed as well, might need to pin this as <11.0.0 regardless of ruby version.

@atrepca
Copy link
Contributor Author

atrepca commented Mar 16, 2016

beaker-rspec is in the system_tests group and bundle is skipping that, Travis is running bundle install --without system_tests development, and all builds are green here. I can amend the commit if you still think it's necessary.

@jlambert121
Copy link
Contributor

Yeah, please do. It breaks local tests if you have the beaker gem installed.

@atrepca
Copy link
Contributor Author

atrepca commented Mar 16, 2016

@jlambert121, done.

@jlambert121
Copy link
Contributor

Thanks - and thanks for squashing into a single commit.

jlambert121 added a commit that referenced this pull request Mar 16, 2016
Install rake < 11.0.0 for ruby < 1.9.3
@jlambert121 jlambert121 merged commit c53ac5c into sensu:master Mar 16, 2016
@atrepca atrepca deleted the rake-fix branch March 17, 2016 08:01
@jlambert121
Copy link
Contributor

Reverting as Rake replaced the method as deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants