Initital fix for sensu on windows #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 30, 2016 11:24
Changed windows user and group for sensu config. Also set manage user to false as the current logic is not compatible with windows
|
Sorry I haven't been able to test the change yet. In working through a puppet 4 migration but hope to crack at it before the end of the week. |
|
I have tested this and it works as described. Thank you. |
|
Beautiful. Ty @unclespeedo. @jaxxstorm when I have some time later this month (hopefully) Ill make another pull to support overriding the user as well as creating a local user. The second might be slightly harder due to system permissions, but I could see a reason for users to want to pick a service account that sensu runs on. |
|
My pleasure @dzeleski, feel free to @ me if you need help testing anything on the Windows side. |
cdenneen
added a commit
to cdenneen/sensu-puppet
that referenced
this pull request
Mar 29, 2017
Until better user management for windows installs can be added this is to prevent attempting to create user/group on windows platform regardless of the manage_user parameter. Fixes issue sensu#617 * NOTE: This would have been better as a case statement in a params.pp class but since that isn't implemented this is a crude workaround for the time being. This is also the default requirement for PR sensu#588
cdenneen
added a commit
to cdenneen/sensu-puppet
that referenced
this pull request
Mar 30, 2017
Until better user management for windows installs can be added this is to prevent attempting to create user/group on windows platform regardless of the manage_user parameter. Fixes issue sensu#617 * NOTE: This would have been better as a case statement in a params.pp class but since that isn't implemented this is a crude workaround for the time being. This is also the default requirement for PR sensu#588
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial fix for sensu on windows. This was tested minimally. Further support should be added to override user if needed.
NOTE: you must set manage_user to false on windows