(#658) Manage the when attribute of sensu filters #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch sensu filters are unable to manage the [when attribute](https://sensuapp.org/docs/0.26/reference/filters.html#when-attributes) This patch implements the `when` property on the sensu_filter type and json provider. The `sensu::filter` defined type is also updated to support the `when` parameter. The behavior may be exercised with `vagrant up el7-client`. This will produce `/etc/sensu/conf.d/filters/offhours.json` with the content of: { "filters": { "offhours": { "attributes": { "client": { "environment": "production" } }, "when": { "days": { "all": [ { "begin": "2:00 AM", "end": "1:00 AM" } ] } }, "negate": false } } } Resolves sensu#658
jeffmccune
force-pushed
the
658_support_when_attribute_in_filters
branch
from
e43ab62 to
6721c55
Compare
|
Resolves #658 (Waffle isn't associating this PR with the issue for some reason, trying to nudge it.) |
ghoneycutt
approved these changes
Jul 8, 2017
|
Released in v2.17.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch sensu filters are unable to manage the when
attribute
This patch implements the
whenproperty on the sensu_filter type and jsonprovider. The
sensu::filterdefined type is also updated to support thewhenparameter.The behavior may be exercised with
vagrant up el7-client. This will produce/etc/sensu/conf.d/filters/offhours.jsonwith the content of:Resolves #658