Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH-388) Simplify class notifications #725

Merged
merged 1 commit into from
Jul 9, 2017
Merged

(GH-388) Simplify class notifications #725

merged 1 commit into from
Jul 9, 2017

Conversation

ghoneycutt
Copy link
Collaborator

No description provided.

@ghoneycutt ghoneycutt mentioned this pull request Jul 9, 2017
Closed
@ghoneycutt
Copy link
Collaborator Author

Resolves #388

@jeffmccune
Copy link
Collaborator

LGTM

jeffmccune
jeffmccune approved these changes Jul 9, 2017
View reviewed changes
Copy link
Collaborator

@jeffmccune jeffmccune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Much more readable. Good use of delete_undef_values().

@ghoneycutt ghoneycutt merged commit f175f1c into sensu:master Jul 9, 2017
@ghoneycutt ghoneycutt deleted the 388_simplify_class_notifications branch July 9, 2017 17:27
@ghoneycutt
Copy link
Collaborator Author

Released in v2.19.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffmccune jeffmccune jeffmccune approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghoneycutt @jeffmccune @covataamos