Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support to client config for servicenow, ec2, chef, puppet #772 #773 #774 #775 #807

Merged
merged 1 commit into from
Sep 6, 2017
Merged

Added support to client config for servicenow, ec2, chef, puppet #772 #773 #774 #775 #807

merged 1 commit into from
Sep 6, 2017

Conversation

alvagante
Copy link
Collaborator

@alvagante alvagante commented Sep 1, 2017 •
edited
Loading

Pull Request Checklist

This is a cumulative PR which adds support to Client config for servicenow, ec2, chef and puppet.

Description

Added parameters to sensu class, sensu::client class and sensu_client_config type

Related Issue

Resolves: #772 #773 #774 #775

Motivation and Context

Have configuration parity support to sensu client

How Has This Been Tested?

Spec tests done.
Vagrant tests WIP

General

  • Update README.md with any necessary configuration snippets

  • New parameters are documented

  • New parameters have tests

  • Tests pass - bundle exec rake validate lint spec

@alvagante
Copy link
Collaborator Author

@ghoneycutt In order to speed up works and avoid unnecessary branches and merge operations,
I'd consolidate in a single PR all the client config related issues. That can be this same PR, sanely renamed.
Let me know if ok for you or if you prefer to have separated PR for each issue.

@ghoneycutt
Copy link
Collaborator

I'm good with that as long as the branch is not going to live for over a week, else we should release sooner.

@alvagante
Copy link
Collaborator Author

@ghoneycutt +1, you will have the PR for all the client configs by Monday

@alvagante alvagante changed the title Added servicenow support to client config #775 Added support to client config for servicenow, ec2, chef, puppet #772 #773 #774 #775 Sep 1, 2017
@alvagante alvagante changed the title Added support to client config for servicenow, ec2, chef, puppet #772 #773 #774 #775 WIP Added support to client config for servicenow, ec2, chef, puppet #772 #773 #774 #775 Sep 1, 2017
@alvagante alvagante changed the title WIP Added support to client config for servicenow, ec2, chef, puppet #772 #773 #774 #775 Added support to client config for servicenow, ec2, chef, puppet #772 #773 #774 #775 Sep 1, 2017
@alvagante
Added sensu client params sensu#772 sensu#773 sensu#774 sensu#775
b3585f3 
Added servicenow support to client config (sensu#775)
Added ec2 support to client config (sensu#772)
Added chef  support to client config (sensu#773)
Added puppet support to client config (sensu#774)
@alvagante
Copy link
Collaborator Author

@ghoneycutt this is ready to merge for me.
I've added these new params in the sensu-client vagrant vm, for testing.
Let me know if to keep them or not in test/sensu-client.pp They are safe anyway (client service starts even if none of those technologies is used).

@ghoneycutt ghoneycutt merged commit 826de89 into sensu:master Sep 6, 2017
@ghoneycutt
Copy link
Collaborator

Thank you!

Released in v2.35.0

@cdenneen cdenneen mentioned this pull request Mar 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvagante @ghoneycutt