Fix #820 #846
Fix #820 #846
Conversation
manifests/subscription.pp
Outdated
| @@ -13,7 +13,9 @@ | |||
|
|
|||
| include ::sensu | |||
|
|
|||
| file { "${::sensu::conf_dir}/subscription_${name}.json": | |||
| $sanitized_name=regsubst($name, '[^0-9A-Za-z.-]', '_', 'G') | |||
There was a problem hiding this comment.
Can you please comment on what this function is doing?
There was a problem hiding this comment.
regex explained in words can be really useful so you dont have to dissect what it is doing
| it { should contain_file('/etc/sensu/conf.d/subscription_roundrobin_foo.json').with(:ensure => 'present' ) } | ||
| end | ||
|
|
||
| context 'with char : in title in windows' do |
There was a problem hiding this comment.
Awesome! Love seeing those tests :)
| @@ -34,6 +34,11 @@ def initialize(*args) | |||
| defaultto '/etc/sensu/conf.d/' | |||
| end | |||
|
|
|||
| newparam(:file_name) do | |||
There was a problem hiding this comment.
This should be documented in the README
There was a problem hiding this comment.
Actually in README we document only sensu::subscription and from here we call sensu_client_subscription using the new file_name param (f8b25fe#diff-dbd03c1a865315be6893da851b471baeR29) but not exposing it as param for sensu::subscription.
So either we expose file_name parameter also in sensu::subscription and we document it, or we just leave it a an internal setting that users don't have to mess it.
There was a problem hiding this comment.
ah ok, it can stay internal
|
Released in v2.43.0 |
Should fix #820
Have had to add a new parameter to client_config_register.
Description
Related Issue
Fixes #820 .
Motivation and Context
How Has This Been Tested?
General
Update
README.mdwith any necessary configuration snippetsNew parameters are documented
New parameters have tests
Tests pass -
bundle exec rake validate lint spec