Second attempt for #844 #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvagante
force-pushed
the
844
branch
2 times, most recently
from
9974bf8 to
f46e4ff
Compare
ghoneycutt
reviewed
Nov 22, 2017
tests/provision_enterprise_server.sh
Outdated
| @@ -30,7 +30,8 @@ EOF | |||
| install -o vagrant -g vagrant -m 0644 "$profile" ~vagrant/.bash_profile | |||
|
|
|||
| # setup module dependencies | |||
| puppet module install puppetlabs/rabbitmq | |||
| puppet module install puppet/rabbitmq | |||
| puppet module install puppet/archive | |||
There was a problem hiding this comment.
shouldnt archive get installed as a dependency of rabbitmq?
https://github.com/voxpupuli/puppet-rabbitmq/blob/master/metadata.json#L60
Added option to make rabbitmq work in vagrant environments with voxpupuli module Install also archive module for puppet/rabbitmq setup Added option to make rabbitmq work in vagrant environments with voxpupuli module Re-removed puppetlabs references Removed redundant puppet module command in tests scripts
|
Thanks! Released in v2.41.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time should be better
vagrant environment needed a specific config entry for rabbitmq class in order to work properly.
Pull Request Checklist
Description
Related Issue
Fixes # .
Motivation and Context
How Has This Been Tested?
General
Update
README.mdwith any necessary configuration snippetsNew parameters are documented
New parameters have tests
Tests pass -
bundle exec rake validate lint spec