add sensu version facter (continued) #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghoneycutt
reviewed
Apr 13, 2018
| it do | ||
| File.stubs(:exists?).with('/opt/sensu/embedded/bin/sensu-client').returns(true) | ||
| Facter::Util::Resolution.expects(:exec).with('/opt/sensu/embedded/bin/sensu-client --version 2>&1').returns('0.23.3') | ||
| expect(Facter.value(:sensu_version)).to eql('0.23.3') |
There was a problem hiding this comment.
seems these tests are failing
There was a problem hiding this comment.
You can use this as a reference for stubbing facts
|
This is issue with mocha. Explanation of why be good to use rspec mocks instead of mocha. puppetlabs/puppetlabs_spec_helper@695876f Change in mocha 1.5.0 that breaks tests: Example of rspec mock: https://github.com/treydock/puppet-osg/blob/master/spec/unit/facter/osg_version_spec.rb |
|
@ghoneycutt Fixed tests by using rspec mocks. |
|
Looks good! Could you please squash the commits and keep @bovy89 as a co-author. https://help.github.com/articles/creating-a-commit-with-multiple-authors/ |
Check sensu_version fact for all vagrant boxes Using `facter -p` would require plugin sync which requires setting up puppetserver, defining --custom-dir avoids need for plugin sync Co-authored-by: bovy89 <bovy89@gmail.com> Co-authored-by: Trey Dockendorf <treydock@gmail.com>
|
@ghoneycutt Squashed and co-author change made. |
|
Replaces #818 |
|
Released in v2.52.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #818