-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor sensu_check check_hooks property #956
Conversation
I will update acceptance tests to ensure that valid |
Acceptance tests updated and passing. |
I have local changes that are more complex but valid use of |
…roperty as sorting array of hashes seems to throw errors
Looks like can't use |
@treydock could you please rebase so this will merge |
Rebased in #962 |
Pull Request Checklist
Description
Make sensu_check
check_hooks
property match what is actually output by sensuctl.Related Issue
Relates to #901. Upstream documentation bug here: sensu/sensu-docs#678
Motivation and Context
The type
sensu_check
needs to treatcheck_hooks
property the way it's handled by sensuctl. Previously it was just expecting an array of hooks which isn't correct as hooks associated to a check also have a type like critical or warning. This change ensures validcheck_hooks
are defined.