Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scheduled] flutter pub upgrade && flutter pub upgrade --major-versions #1638

Merged
merged 11 commits into from
Nov 16, 2023

Conversation

@sensuikan1973
Copy link
Owner Author

+ cp /c/Windows/System32/vcruntime140.dll build/windows/runner/Release/
cp: cannot create regular file 'build/windows/runner/Release/': No such file or directory
msix created: build\windows\x64\runner\Release\pedax.msix

@sensuikan1973
Copy link
Owner Author

diff --git a/windows/flutter/CMakeLists.txt b/windows/flutter/CMakeLists.txt
index 7aa7da4..50d6851 100644
--- a/windows/flutter/CMakeLists.txt
+++ b/windows/flutter/CMakeLists.txt
@@ -9,6 +9,11 @@ include(${EPHEMERAL_DIR}/generated_config.cmake)
 # https://github.com/flutter/flutter/issues/57146.
 set(WRAPPER_ROOT "${EPHEMERAL_DIR}/cpp_client_wrapper")
 
+# Set fallback configurations for older versions of the flutter tool.
+if (NOT DEFINED FLUTTER_TARGET_PLATFORM)
+  set(FLUTTER_TARGET_PLATFORM "windows-x64")
+endif()
+
 # === Flutter Library ===
 set(FLUTTER_LIBRARY "${EPHEMERAL_DIR}/flutter_windows.dll")
 
@@ -90,7 +95,7 @@ add_custom_command(
   COMMAND ${CMAKE_COMMAND} -E env
     ${FLUTTER_TOOL_ENVIRONMENT}
     "${FLUTTER_ROOT}/packages/flutter_tools/bin/tool_backend.bat"
-      windows-x64 $<CONFIG>
+      ${FLUTTER_TARGET_PLATFORM} $<CONFIG>
   VERBATIM
 )
 add_custom_target(flutter_assemble DEPENDS

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

Merging #1638 (c6a066f) into main (aeab5ab) will increase coverage by 0.33%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1638      +/-   ##
==========================================
+ Coverage   93.67%   94.01%   +0.33%     
==========================================
  Files          52       52              
  Lines        1503     1503              
==========================================
+ Hits         1408     1413       +5     
+ Misses         95       90       -5     
Flag Coverage Δ
integration_test 70.92% <ø> (+0.33%) ⬆️
macos 93.08% <ø> (?)
ubuntu 93.47% <ø> (-0.14%) ⬇️
widget_test 90.34% <ø> (+0.40%) ⬆️
windows 93.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@sensuikan1973 sensuikan1973 merged commit cb1f097 into main Nov 16, 2023
18 checks passed
@sensuikan1973 sensuikan1973 deleted the cron_upgrade_flutter_dependencies branch November 16, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants