Skip to content

Fix: empty HTML content not always detected in _process_html_content #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dar326 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: empty HTML content not always detected in _process_html_content #42

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b89794b
Add files via upload
dar326 Jul 28, 2025
13062ae
Handle case when html is None
dar326 Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/opendeepsearch/context_building/process_sources_pro.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ async def _fetch_html_contents(self, links: List[str]) -> List[str]:
return [x['no_extraction'].content for x in raw_contents.values()]

def _process_html_content(self, html: str, query: str) -> str:
if not html:
if not html or not html.strip():
return ""
try:
# Split the HTML content into chunks
Expand Down Expand Up @@ -100,4 +100,4 @@ def _update_sources_with_content(
for (i, source), html in zip(valid_sources, html_contents):
source['html'] = self._process_html_content(html, query)
# sources[i] = source
return sources
return sources