Fix ROMAConfig serialization in ExecutionService and add free_tier config profile #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix ExecutionService to use config_to_dict() instead of dict(config) - Add _convert_to_serializable() to handle nested Pydantic models - Add missing free_tier.yaml profile - Fix general.yaml runtime timeout validation - Update test mocks to use OmegaConf Fixes sentient-agi#71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #71 - "API calls don't work"
This PR fixes the
'ROMAConfig' object is not iterableerror that occurs when creating executions via the API.Root Cause
ExecutionService was using dict(config) which fails on Pydantic dataclasses. Additionally, the existing config_to_dict() used
OmegaConf.structured()which couldn't handle nested Pydantic BaseModel objects like CheckpointConfig.Changes
Serialization Fixes
Configuration Fixes
Test Fixes
OmegaConf.create()instead ofMagicMockTesting
free_tierandgeneralprofiles