Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SnowMaskTask when dealing with empty patches #793

Merged
merged 9 commits into from
Jun 13, 2024
Merged

Conversation

mlubej
Copy link
Contributor

@mlubej mlubej commented Jun 12, 2024

Was easier to return something early, instead of fixing the shapes

@mlubej mlubej requested a review from zigaLuksic June 12, 2024 15:02
@mlubej mlubej self-assigned this Jun 12, 2024
@zigaLuksic
Copy link
Collaborator

cv2 is really making our life difficult with all its weird custom types 🙃

Copy link
Collaborator

@zigaLuksic zigaLuksic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did this fail before? I dont see any explicit loops in the execute body

would be great to have a test :D

@mlubej
Copy link
Contributor Author

mlubej commented Jun 13, 2024

where did this fail before? I dont see any explicit loops in the execute body

It happens in the _apply_dilation method

Will update

@zigaLuksic zigaLuksic merged commit de1501d into develop Jun 13, 2024
7 checks passed
@zigaLuksic zigaLuksic deleted the empty-batch-fix branch June 13, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants