Experimental new config setup #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlubej
reviewed
Mar 16, 2023
|
You can also remove the last two lines in |
Kept them intentionally for now. We can remove it in the future, but since it's harmless I'd keep it as another layer of security until the new config has been accepted as the correct solution. |
mlubej
reviewed
Mar 17, 2023
mlubej
reviewed
Mar 17, 2023
Co-authored-by: Matic Lubej <matic.lubej@sinergise.com>
…ub/sentinelhub-py into experimental-new-config-setup
|
Got worried for a second that the tests could cause issues, but the approach we used actually transfers over very nicely |
mlubej
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
~/.config/sentinelhub/config.jsonfor Linux users)strandrepr(not sure why that was not the case...)a separate MR shall introduce user profiles to remedy the loss of 'managing-different-credentials-through-python-envs'