Skip to content

Upgrading to latest version of SDK for React Native as well as for Sentry #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

sentryadam0000345
Copy link

@sentryadam0000345 sentryadam0000345 commented Sep 23, 2020

@thinkocapo
Copy link
Contributor

thinkocapo commented Oct 6, 2020

@sentryadam0000345 starting my review. I see 2.7million lines got added. Many may be for 'build' related items, which we want to ignore (remember the Rust demo?). The current gitignore file needs to be updated. It's not covering all these 'build' items, because you changed the overall project structure. That's not inherently bad, but I"ll need to do some research and verify it's okay.

Previously it was

./ReactNativeDemo
./ReactNativeDemo/android
./ReactNative/ios

Your PR has it as:

./android
./ios

Could you check Files Changed, find anything from a 'build' subdirectory, then go to your terminal and rm (remove) those files from source control (don't worry, they'll get regenerated when you next run the app, but DO NOT run the app yet). Now that they've been removed, do git add . git commit -m "removed build files".

In current React Native master branch, notice there are no build subdirectories.

Recall this is similar to what we went through with the Rust demo. In the future, you can run git status before you commit and this way you can see if it's trying to check the 'build' directories into Version Control. Then, update .gitignore with the build directories, so they're no longer tracked (re-run git status and you'll see they're no longer mentioned).

@thinkocapo
Copy link
Contributor

@sentryadam0000345 can you rename this PR?

What is the goal of this PR? Are you upgrading the SDK version? Testing out new features? Write about this in the Description.

Copy link

@rohitkataria-sentryio rohitkataria-sentryio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a suggestion that we move to "sentry_react_native" repo and abandon "react-native" repo . With the learnings I got from Adam to get the demo working, I used it and created sentry_react_native repo. The repo's footprint is extremely lightweight at 1.3 MB. See: https://github.com/sentry-demos/sentry_react_native#why-so-many-files . Happy to get on a call .

@thinkocapo thinkocapo requested a review from ndmanvar October 6, 2020 16:03
@ndmanvar
Copy link
Contributor

ndmanvar commented Oct 6, 2020

let's centralize this. I agree with Will + Rohit.
Although the name of this org/repo should be sentry-demos/react-native. (We can rename after the fact).
Let's keep the build/generate-files as .gitignored

Looks like Rohit's gitignore takes care of a lot of this:
https://github.com/sentry-demos/sentry_react_native/blob/master/.gitignore#L7-L26

@sentryadam0000345 sentryadam0000345 changed the title Adam's branch Upgrading to latest version of SDK for React Native as well as for Sentry Oct 7, 2020
@sentryadam0000345
Copy link
Author

@thinkocapo branch renamed and description updated

@sentryadam0000345
Copy link
Author

@thinkocapo ok will do in the future thanks, "Recall this is similar to what we went through with the Rust demo. In the future, you can run git status before you commit and this way you can see if it's trying to check the 'build' directories into Version Control. Then, update .gitignore with the build directories, so they're no longer tracked (re-run git status and you'll see they're no longer mentioned)."

@sentryadam0000345
Copy link
Author

@ndmanvar @thinkocapo let me know what needs to be done here, I can sync with Rohit today to get his work synced with mine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants