-
Notifications
You must be signed in to change notification settings - Fork 8
Upgrading to latest version of SDK for React Native as well as for Sentry #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Upgrading to latest version of SDK for React Native as well as for Sentry #10
Conversation
@sentryadam0000345 starting my review. I see 2.7million lines got added. Many may be for 'build' related items, which we want to ignore (remember the Rust demo?). The current gitignore file needs to be updated. It's not covering all these 'build' items, because you changed the overall project structure. That's not inherently bad, but I"ll need to do some research and verify it's okay. Previously it was
Your PR has it as:
Could you check Files Changed, find anything from a 'build' subdirectory, then go to your terminal and In current React Native Recall this is similar to what we went through with the Rust demo. In the future, you can run |
@sentryadam0000345 can you rename this PR? What is the goal of this PR? Are you upgrading the SDK version? Testing out new features? Write about this in the Description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a suggestion that we move to "sentry_react_native" repo and abandon "react-native" repo . With the learnings I got from Adam to get the demo working, I used it and created sentry_react_native repo. The repo's footprint is extremely lightweight at 1.3 MB. See: https://github.com/sentry-demos/sentry_react_native#why-so-many-files . Happy to get on a call .
let's centralize this. I agree with Will + Rohit. Looks like Rohit's gitignore takes care of a lot of this: |
@thinkocapo branch renamed and description updated |
@thinkocapo ok will do in the future thanks, "Recall this is similar to what we went through with the Rust demo. In the future, you can run git status before you commit and this way you can see if it's trying to check the 'build' directories into Version Control. Then, update .gitignore with the build directories, so they're no longer tracked (re-run git status and you'll see they're no longer mentioned)." |
@ndmanvar @thinkocapo let me know what needs to be done here, I can sync with Rohit today to get his work synced with mine |
Native Crash: https://sentry.io/organizations/testorg-az/issues/1901607584/?project=5432830&query=is%3Aunresolved
Android Javascript error: https://sentry.io/organizations/testorg-az/issues/1908786323/?project=5230364&referrer=slack
Android Native Crash: https://sentry.io/organizations/testorg-az/issues/1906318296/?project=5411157&query=is%3Aunresolved
Upgrading to latest version of SDK for React Native as well as for Sentry