Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update geoip job hooks and volume handling #1529

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

patsevanton
Copy link
Contributor

@patsevanton patsevanton commented Oct 11, 2024

Description

This pull request introduces several improvements to the GeoIP job and volume configuration within the Sentry Helm chart. The changes are aimed at enhancing the reliability and flexibility of the GeoIP setup.

Changes Overview

  1. GeoIP Job Hook Update:

    • Changed the hook from pre-install to post-install with a weight of 9.
    • Added an init container to create the GeoIP directory if it doesn't exist.
  2. Persistent Volume Claim (PVC) Annotations:

    • Added annotations to the PVC to ensure it is created before the GeoIP job runs.
  3. Conditional Volume Mounting:

    • Updated the volume mounting logic to only mount the GeoIP volume if both volumeName and accountID are defined.
  4. Dynamic PVC Claim Name:

    • Updated the PVC claim name to use the dynamic value from Values.geodata.volumeName.
  5. Values.yaml Comments:

    • Enhanced comments in values.yaml to provide clearer guidance on configuring GeoIP settings.

Related Pull Requests:


Feel free to review and provide feedback. Thank you!

@patsevanton
Copy link
Contributor Author

@Mokto please review PR

@Mokto Mokto merged commit 886eb5f into sentry-kubernetes:develop Oct 12, 2024
2 checks passed
@Mokto Mokto mentioned this pull request Oct 12, 2024
@patsevanton
Copy link
Contributor Author

@sdernbach-ionos use tag 25.13.3

@patsevanton patsevanton deleted the geoip-install-job-new branch October 13, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants