-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add geoip support to sentry deployment #1516
feat: add geoip support to sentry deployment #1516
Conversation
We should allow the user to provide the GeoIP configuration via a secret. Otherwise, we are adding tech-debt like we had when being unable to provide the Redis password via a secret. A license key is not something that should be stored in plain text anywhere as its a "secret". |
@swade1987 You want to instead of indicating
specify
|
All the configuration options for the geodata could be passed as a single secret. |
{{- if (eq "-" .Values.geodata.persistence.storageClass) }} | ||
storageClassName: "" | ||
{{- else }} | ||
storageClassName: "{{ .Values.geodata.persistence.storageClass }}" | ||
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patsevanton according to the comment in the values.yaml shouldn't that be:
{{- if .Values.geodata.persistence.storageClass }}
{{- if (eq "-" .Values.geodata.persistence.storageClass) }}
storageClassName: ""
{{- else }}
storageClassName: "{{ .Values.geodata.persistence.storageClass }}"
{{- end }}
{{- end }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sdernbach-ionos please review PR #1524
This pull request introduces support for GeoIP in the Sentry deployment. The changes include:
New Configuration Options:
values.yaml
file.accountID
,licenseKey
,editionIDs
,persistence
,volumeName
,mountPath
, andpath
.New Templates:
deployment-geoip-job.yaml
template to handle the GeoIP database update job.pvc-geoip.yaml
template for the PersistentVolumeClaim (PVC) to store the GeoIP database.secret-geoip-env.yaml
template to manage the environment variables required for GeoIP configuration.Volume Mounts:
deployment-relay.yaml
,deployment-sentry-web.yaml
, anddeployment-sentry-worker-events.yaml
templates.Documentation:
README.md
file with an example of how to configure GeoIP in the Sentry deployment.