Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Voltage conversion from milliVolt to Volt #62

Closed
CherfaElyes opened this issue Apr 24, 2024 · 0 comments · Fixed by #63
Closed

Adding Voltage conversion from milliVolt to Volt #62

CherfaElyes opened this issue Apr 24, 2024 · 0 comments · Fixed by #63
Assignees
@CherfaElyes
Labels
bug Something isn't working enhancement New feature or request
Milestone
v1.0.01

Comments

@CherfaElyes
Copy link
Contributor

CherfaElyes commented Apr 24, 2024 •
edited
Loading

Specification

In the actual connectors, the conversion from MilliVolt to Volt is missing, which lead to 1000 times bigger values.

Solution

Call the milliVolt2Volt function in the connectors as follows:
hw.voltage: milliVolt2Volt(...)
@CherfaElyes CherfaElyes added bug Something isn't working enhancement New feature or request labels Apr 24, 2024
@CherfaElyes CherfaElyes self-assigned this Apr 24, 2024
CherfaElyes added a commit that referenced this issue Apr 25, 2024
@CherfaElyes
Issue #62: Adding Voltage conversion from MilliVolt to Volt
6f8e5ac 
* Added `milliVolt2Volt` conversion on `hw.voltage` and `hw.voltage.limit` values to convert values to V.
@CherfaElyes CherfaElyes linked a pull request Apr 25, 2024 that will close this issue
Issue #62: Adding Voltage conversion from MilliVolt to Volt #63
Merged
NassimBtk added a commit that referenced this issue Apr 26, 2024
@NassimBtk
Merge pull request #63 from sentrysoftware/feature/issue-62-adding-vo…
339f631 
…ltage-conversion-from-millivolt-to-volt

Issue #62: Adding Voltage conversion from MilliVolt to Volt
@NathalieLe NathalieLe added this to the 1.0.01 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CherfaElyes CherfaElyes

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
v1.0.01
2 participants
@NathalieLe @CherfaElyes