Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIB2NT: Bad ExcludeMatchingLines regex #95

Closed
NassimBtk opened this issue Jul 21, 2024 · 0 comments · Fixed by #96
Closed

MIB2NT: Bad ExcludeMatchingLines regex #95

NassimBtk opened this issue Jul 21, 2024 · 0 comments · Fixed by #96
Assignees
@CherfaElyes
Milestone
v1.0.05

Comments

@NassimBtk
Copy link
Member

Specification

In the MI2BNT connector, the ExcludeMatchingLines regex is incorrect. The double quotes are missing, leading to a bad regex where the job will continue to include unwanted monitors.

Current incorrect configuration:

         - type: excludeMatchingLines
            column: 2
            regExp: \\(WAN\\)\\|\\(QoS\\)\\|\\([Ff]ilter\\)\\|\\([Ss]witch\\)\\|\\(57 41 4E 20\\)\\|\\(4D 69 63 72 6F 73 6F 66 74\\)

Correct configuration:

         - type: excludeMatchingLines
            column: 2
            regExp: "\\(WAN\\)\\|\\(QoS\\)\\|\\([Ff]ilter\\)\\|\\([Ss]witch\\)\\|\\(57 41 4E 20\\)\\|\\(4D 69 63 72 6F 73 6F 66 74\\)"
CherfaElyes added a commit that referenced this issue Jul 22, 2024
@CherfaElyes
Issue #95: MIB2NT: Bad ExcludeMatchingLines regex
7a5abbe 
* Surrounded some Regular Expressions with double quotes as in HDFs.
@CherfaElyes CherfaElyes linked a pull request Jul 22, 2024 that will close this issue
Issue #95: MIB2NT: Bad ExcludeMatchingLines regex #96
Merged
NassimBtk added a commit that referenced this issue Jul 22, 2024
@NassimBtk
Merge pull request #96 from sentrysoftware/feature/issue-95-mib2nt-ba…
2f72047 
…d-excludematchinglines-regex

Issue #95: MIB2NT: Bad ExcludeMatchingLines regex
@NathalieLe NathalieLe added this to the 1.0.05 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CherfaElyes CherfaElyes

Labels
None yet
Projects
None yet
Milestone
v1.0.05
Development

Successfully merging a pull request may close this issue.

Issue #95: MIB2NT: Bad ExcludeMatchingLines regex sentrysoftware/metricshub-community-connectors
3 participants
@NassimBtk @NathalieLe @CherfaElyes