Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #112: Select windows processes by user name and domain #147

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Issue #112: Select windows processes by user name and domain #147

merged 5 commits into from
Dec 5, 2024

Conversation

MedMaalej
Copy link
Contributor

  • Update WindowsProcess.yaml

@MedMaalej MedMaalej self-assigned this Nov 21, 2024
@MedMaalej MedMaalej added enhancement New feature or request developer_tested The changes are tested by the developer labels Nov 21, 2024
NassimBtk
NassimBtk requested changes Nov 21, 2024
View reviewed changes
Copy link
Member

@NassimBtk NassimBtk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format changed

NassimBtk and others added 2 commits November 21, 2024 10:45
@MedMaalej
Copy link
Contributor Author

I checked the logs, here is a sample output of the connector:

WinProcess

It shows the processes of a given user selected using the regex matchUser and / or matchDomain in the connector file.
The screenshot confirms that we retrieved successfully the domain and the user of the account associated to a given process.

The configuration in metricshub.yaml was as below:

resources:
  localhost:
    attributes:
      host.name: localhost
      host.type: win
    protocols:
      wmi:
        timeout: 120
    connectors: [+WindowsProcess]

@MedMaalej MedMaalej requested a review from NassimBtk November 21, 2024 13:50
@NassimBtk NassimBtk linked an issue Nov 22, 2024 that may be closed by this pull request
In Windows Process connector, retrieve the process user name and allow to select the process with user name #112
Closed
@NassimBtk
Copy link
Member

NassimBtk commented Nov 25, 2024 •
edited
Loading

@bertysentry what do you think?

@NassimBtk NassimBtk merged commit 2fd49ea into main Dec 5, 2024
1 check passed
@NassimBtk NassimBtk deleted the feature/issue-112-Select-windows-processes-by-username-and-domain branch December 5, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertysentry bertysentry bertysentry approved these changes

@NassimBtk NassimBtk NassimBtk approved these changes

@MarcDouguedroit MarcDouguedroit Awaiting requested review from MarcDouguedroit

@TNohaic TNohaic Awaiting requested review from TNohaic

@FK-sentry FK-sentry Awaiting requested review from FK-sentry

@CherfaElyes CherfaElyes Awaiting requested review from CherfaElyes

@SafaeAJ SafaeAJ Awaiting requested review from SafaeAJ

Assignees

@MedMaalej MedMaalej

Labels
developer_tested The changes are tested by the developer enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In Windows Process connector, retrieve the process user name and allow to select the process with user name
3 participants
@MedMaalej @NassimBtk @bertysentry