Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #148: [Linux] Enhance filesystem utilization calculation #149

Conversation

NassimBtk
Copy link
Member

@NassimBtk NassimBtk commented Nov 21, 2024

This pull request includes an important update to the src/main/connector/system/Linux/Linux.yaml file, specifically within the monitors section. The change modifies the awk script used for processing disk usage information.

Key change:

Testing:
image

root@nb-debian:/opt/workspace/opentelemetry-collector-contrib# /usr/bin/df -B1
Filesystem       1B-blocks        Used  Available Use% Mounted on
udev            2053718016           0 2053718016   0% /dev
tmpfs            413818880    41848832  371970048  11% /run
/dev/sda1      42091429888 32452136960 7574675456  82% /
tmpfs           2069078016           0 2069078016   0% /dev/shm
tmpfs              5242880           0    5242880   0% /run/lock
tmpfs           2069078016           0 2069078016   0% /sys/fs/cgroup
tmpfs            413814784           0  413814784   0% /run/user/0

* Updated usage calculation in the awk script
@NassimBtk NassimBtk added the developer_tested The changes are tested by the developer label Nov 21, 2024
@NassimBtk NassimBtk linked an issue Nov 21, 2024 that may be closed by this pull request
NassimBtk and others added 2 commits November 22, 2024 09:44
Added reserved space computation

Co-authored-by: Bertrand Martin <32521698+bertysentry@users.noreply.github.com>
- Update the Linux connector mapping to calculate reserved space usage.
Copy link
Member

@bertysentry bertysentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether we should update the system dashboards in Grafana. But this is good! 😅

Nothing like real life testing... 😉

@NassimBtk NassimBtk merged commit 1b7938c into main Nov 22, 2024
1 check passed
@NassimBtk NassimBtk deleted the feature/issue-148-linux-enhance-filesystem-utilization-calculation branch November 22, 2024 12:41
@NassimBtk
Copy link
Member Author

System dashboards updates: sentrysoftware/grafana-dashboards#26.

@NassimBtk NassimBtk added this to the 1.0.07 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer_tested The changes are tested by the developer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux: Enhance filesystem utilization calculation
2 participants