Issue #20: Create Windows.yaml #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created Windows.yaml in community connectors.
alexdgilbert
requested review from
MedMaalej,
NassimBtk,
MarcDouguedroit,
bertysentry,
FK-sentry,
CherfaElyes and
kawtarBK9
bertysentry
requested changes
Jan 19, 2024
- Added Network and Pagefile collection - Renamed sources for clarity - Removed job type clarification for simple jobs
- Fixed typo in service state metric
bertysentry
requested changes
Jan 22, 2024
There was a problem hiding this comment.
A few more changes are needed, please (see my comments).
Also, we need the system.disk.* metrics based on Physical Disks performance object.
- Added physical_disk monitor - Refined and enhanced paging
- Fixed inverted soft and hard faults in paging - Simplified code to match new engine changes
bertysentry
approved these changes
Feb 5, 2024
NassimBtk
approved these changes
Feb 5, 2024
NassimBtk
approved these changes
Feb 5, 2024
NassimBtk
deleted the
20-added-windows-connector-to-community-repository
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created Windows.yaml in community connectors.