Issue #85: Added new metrics system.uptime #86
Conversation
NassimBtk
changed the title
| osInformation: | ||
| type: commandLine | ||
| commandLine: | | ||
| os_info=$(cat /etc/os-release | grep -E '^(NAME|VERSION="[0-9].*")' | tr -d '"') |
There was a problem hiding this comment.
It's actually more efficient and robust to "execute" /etc/os-release and then echo the required env variables. The below script will achieve the same result with much less processes:
. /etc/os-release
echo "$NAME;$VERSION;`uname -r`"| kernel_version=$(cat /proc/version | awk '{print $3}') | ||
| echo "$os_info; $kernel_version" | ||
| computes: | ||
| - type: awk |
There was a problem hiding this comment.
This compute step is unnecessary.
| version: $2 | ||
| os_version: $3 | ||
| metrics: | ||
| system.uptime: ${source::uptime} |
There was a problem hiding this comment.
Urgl! @NassimBtk Is this even supported? 😅
There was a problem hiding this comment.
Yes @bertysentry, I totally forgot we support that 🤦♂️, it will avoid unnecessary joins.
| # Uptime (timestamp) | ||
| uptime: | ||
| type: commandLine | ||
| commandLine: expr $(date +%s) - $(awk '{print int($1)}' /proc/uptime) |
There was a problem hiding this comment.
Uptime is supposed to be the number of seconds since last boot, which is what we have in /proc/uptime (logically). You don't need to do all this logic, and you don't even need this uptime source.
Let's merge everything in 1 script:
sources:
osInformation:
type: commandLine
commandLine: |
. /etc/os-release
echo "$NAME;$VERSION;`uname -r`;`cut -d. -f1 /proc/uptime`"
mapping:
source: ${source::osInformation}
attributes:
id: $3
name: $1
version: $2
os_version: $3
metrics:
system.uptime: $4| unit: By | ||
| system.uptime: | ||
| description: Timestamp of the system's last startup. |
There was a problem hiding this comment.
No, uptime is the time elapsed since last boot.
| uptime: | ||
| type: wmi | ||
| namespace: root\CIMv2 | ||
| query: SELECT LastBootUpTime FROM Win32_OperatingSystem |
There was a problem hiding this comment.
Use SELECT SystemUpTime FROM Win32_PerfFormattedData_PerfOS_System to get the system uptime (and not the date of the last reboot).
| namespace: root\CIMv2 | ||
| query: SELECT SystemUpTime FROM Win32_PerfFormattedData_PerfOS_System | ||
| mapping: | ||
| source: ${source::osInformation} |
There was a problem hiding this comment.
TBH, I think it would be safer to make a table join on osInformation and uptime, because mapping is supposed to you 1 resulting source. Using system.uptime: ${source::uptime} works just by chance 😅
NassimBtk
deleted the
85-add-os-information-to-linux-and-windows-connectors
branch
The system_uptime metric provides the timestamp of the system's last boot. This metric is crucial for monitoring the system's uptime by offering the exact time at which the system was last restarted. Additionally, this metric includes labels that provide detailed information about the operating system.
Labels: