Add support for running tests in a Docker container #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlecocq
approved these changes
Jan 2, 2020
|
I almost did that with this PR, but then I figured I would just be removing something that currently works, so it might as well stay in there for now. The only reason I can see to drop Vagrant support is if for some reason major changes needed to be made to the Vagrant part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #119 I had issues pulling the Vagrant box, so I decided to simplify things by using Docker.
This adds PR a
test-dockerrule to theMakefilewhich builds a container and runs the tests in it before deleting it.