Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 5.2 #158

Merged
merged 68 commits into from
May 5, 2021
Merged

Version 5.2 #158

merged 68 commits into from
May 5, 2021

Conversation

sepandhaghighi
Copy link
Owner

Reference Issues/PRs

#95 #149 #151

What does this implement/fix? Explain your changes.

Version 5.2

Any other comments?

sepandhaghighi and others added 30 commits January 27, 2021 17:22
@sepandhaghighi
feat : test.yml added #149
4241e75
@sepandhaghighi
fix : test.yml updated #149
845e48b
@sepandhaghighi
del : appveyor.yml removed #149
52a3236
@sepandhaghighi
del : .travis folder removed #149
806aa59
@sepandhaghighi
del : .travis.yml removed #149
2e1d43c
@sepandhaghighi
fix : minor edit in version to test action #149
dbf9076
@sepandhaghighi
fix : version fixed #149
fc11d1b
@sepandhaghighi
doc : CI badge added to README #149
a70738c
@sepandhaghighi
doc : CHANGELOG updated #149
580e36d
@sepandhaghighi
fix : pythonpublish.yml renamed to publish.yml
be68585
@sadrasabouri
Merge pull request #150 from sepandhaghighi/github_action
7c34f3f 
GitHub action
@sepandhaghighi
font : 5 new fonts added #151
c96c390
@sepandhaghighi
fix : tests updated #151
4b79f17
@sepandhaghighi
fix : minor edit in fonts name #151
7cdba05
@sepandhaghighi
doc : CHANGELOG updated #151
67fbb5f
@sepandhaghighi
doc : font counters updated #151
3a5f627
@sepandhaghighi
doc : FontList.ipynb updated #151
d998cb6
@sepandhaghighi
fix : autopep8 #151
9b5c124
@sepandhaghighi
fix : minor edit in tests #151
455ed55
@sepandhaghighi
doc : README reference section updated #151
8188ca5
@sadrasabouri
Merge pull request #152 from sepandhaghighi/new_fonts
27a4f10 
New fonts
@sepandhaghighi
decor : new decors added #151
a203e9a
@sepandhaghighi
fix : DECORATIONS_MAP updated #151
a94128a
@sepandhaghighi
fix : tests updated #151
50eba0f
@sepandhaghighi
doc : decor counters updated #151
567a646
@sepandhaghighi
doc : DecorList.ipynb updated #151
037b598
@sepandhaghighi
doc : CHANGELOG updated #151
03aca0d
@sepandhaghighi
fix : minor edit in heart11 decor #151
ecad642
@sadrasabouri
Merge pull request #153 from sepandhaghighi/new_decors
ee1839f 
New Decors
@sadrasabouri
add : requirements-splitter.py added.
2788856
sepandhaghighi and others added 16 commits March 16, 2021 15:50
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2021 •
edited
Loading

Codecov Report

Merging #158 (b4622cc) into master (367f50b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #158   +/-   ##
=======================================
  Coverage   90.88%   90.88%           
=======================================
  Files           1        1           
  Lines         274      274           
  Branches       74       74           
=======================================
  Hits          249      249           
  Misses         23       23           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 367f50b...b4622cc. Read the comment docs.

@sepandhaghighi sepandhaghighi added this to the art 5.2 milestone Apr 27, 2021
This was linked to issues Apr 27, 2021
Playing cards in Unicode #95
Closed
Migrating to GitHub Actions #149
Closed
fancytextpro.com #151
Closed
@sepandhaghighi
Copy link
Owner Author

@sadrasabouri Hi
Please complete this review until Wednesday - 2021-05-05 - 11:59 AM GMT+3:30
Notice: Only review, don't need to merge

sadrasabouri
sadrasabouri reviewed Apr 28, 2021
View reviewed changes
README.md Outdated
Comment on lines 841 to 859
`1KtNLEEeUbTEK9PdN6Ya3ZAKXaqoKUuxCy`
<h4>Ethereum</h4>
`0xcD4Db18B6664A9662123D4307B074aE968535388`
<h4>Litecoin</h4>
`Ldnz5gMcEeV8BAdsyf8FstWDC6uyYR6pgZ`
<h4>Doge</h4>
`DDUnKpFQbBqLpFVZ9DfuVysBdr249HxVDh`
<h4>Tron</h4>
`TCZxzPZLcJHr2qR3uPUB1tXB6L3FDSSAx7`
<h4>Ripple</h4>
`rN7ZuRG7HDGHR5nof8nu5LrsbmSB61V1qq`
<h4>Binance Coin</h4>
`bnb1zglwcf0ac3d0s2f6ck5kgwvcru4tlctt4p5qef`
<h4>Tether</h4>
`0xcD4Db18B6664A9662123D4307B074aE968535388`
<h4>Dash</h4>
`Xd3Yn2qZJ7VE8nbKw2fS98aLxR5M6WUU3s`
<h4>Stellar</h4>
`GALPOLPISRHIYHLQER2TLJRGUSZH52RYDK6C3HIU4PSMNAV65Q36EGNL`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job.
Can't we make some link kind of link which direct who wants to donate to a special website which he/she can donate us much easier than copy-paste the wallet?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only accept cryptocurrency, so there is no problem ;-)

sadrasabouri
sadrasabouri approved these changes Apr 28, 2021
View reviewed changes
Copy link
Collaborator

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, ready to go 🚀
I left a tiny comment. Hope it can help us.

@sepandhaghighi sepandhaghighi merged commit 5396a4d into master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadrasabouri sadrasabouri sadrasabouri approved these changes

Assignees
No one assigned
Labels
release
Projects
None yet
Milestone
art 5.2
Development

Successfully merging this pull request may close these issues.

fancytextpro.com Migrating to GitHub Actions Playing cards in Unicode
3 participants
@sepandhaghighi @codecov-commenter @sadrasabouri