Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 5.9 #221

Merged
merged 4 commits into from
Mar 16, 2023
Merged

Version 5.9 #221

merged 4 commits into from
Mar 16, 2023

Conversation

sepandhaghighi
Copy link
Owner

@sepandhaghighi sepandhaghighi commented Mar 6, 2023

Reference Issues/PRs

fix #211
fix #207

What does this implement/fix? Explain your changes.

Version 5.9

Any other comments?

@sepandhaghighi sepandhaghighi added this to the art 5.9 milestone Mar 6, 2023
@sepandhaghighi sepandhaghighi self-assigned this Mar 6, 2023
@sepandhaghighi
Copy link
Owner Author

@sadrasabouri Hi
Please complete this review until Wednesday - 2023-03-08 - 11:59 AM GMT+3:30
Notice: Only review, don't need to merge

@sadrasabouri
Copy link
Collaborator

It seems Codacy warning is just a false positive and all things are good for release.

@codecov-commenter
Copy link

Codecov Report

Merging #221 (f3fe1e6) into dev (cf7f6ed) will not change coverage.
The diff coverage is n/a.

❗ Current head f3fe1e6 differs from pull request most recent head cddfb9d. Consider uploading reports for the commit cddfb9d to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##              dev     #221   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files           7        7           
  Lines        1163     1163           
  Branches       74       74           
=======================================
  Hits         1161     1161           
  Misses          1        1           
  Partials        1        1           
Impacted Files Coverage Δ
art/art_param.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sepandhaghighi sepandhaghighi merged commit 09f9e4a into dev Mar 16, 2023
@sepandhaghighi sepandhaghighi deleted the release branch March 16, 2023 12:20
This was linked to issues Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

console_scripts entry point www.toolcalculator.com
3 participants