Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor edits #529

Merged
merged 3 commits into from
Dec 30, 2023
Merged

Minor edits #529

merged 3 commits into from
Dec 30, 2023

Conversation

sepandhaghighi
Copy link
Owner

@sepandhaghighi sepandhaghighi commented Dec 30, 2023 •
edited
Loading

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • .keys() method call removed
  • autopep8.bat and autopep8.sh updated

Any other comments?

@sepandhaghighi sepandhaghighi self-assigned this Dec 30, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 30, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d492ebe) 99.33% compared to head (d9cb10b) 99.33%.

Files Patch % Lines
pycm/pycm_output.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #529      +/-   ##
==========================================
- Coverage   99.33%   99.33%   -0.00%     
==========================================
  Files          14       14              
  Lines        3112     3111       -1     
  Branches      467      467              
==========================================
- Hits         3091     3090       -1     
  Misses          8        8              
  Partials       13       13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sepandhaghighi sepandhaghighi added this to the PYCM 4.1 milestone Dec 30, 2023
@sepandhaghighi sepandhaghighi marked this pull request as ready for review December 30, 2023 17:38
sadrasabouri
sadrasabouri approved these changes Dec 30, 2023
View reviewed changes
Copy link
Collaborator

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sadrasabouri sadrasabouri merged commit 7f270ae into dev Dec 30, 2023
47 checks passed
@sadrasabouri sadrasabouri deleted the minor_edits branch December 30, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadrasabouri sadrasabouri sadrasabouri approved these changes

Assignees

@sepandhaghighi sepandhaghighi

Labels
minor refactoring
Projects
None yet
Milestone
PYCM 4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@sepandhaghighi @sadrasabouri