Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple typo in test paths generation. #418

Closed
emonsler opened this issue Sep 5, 2023 · 1 comment
Closed

Simple typo in test paths generation. #418

emonsler opened this issue Sep 5, 2023 · 1 comment

Comments

@emonsler
Copy link

emonsler commented Sep 5, 2023

Describe the bug
The generated test path in two tests does not occur under the specified tmp_path.

To Reproduce
Run tests under test_delta.py.

Expected behavior
Test paths generated should be under the passed tmp_path.

OS, DeepDiff version and Python version (please complete the following information):

  • DeepDiff Version 6.3.1

Additional context
There appears to be a simple typo, occurring twice.

path = os.path.join('tmp_path, delta_test2.delta')

path = os.path.join('tmp_path, delta_test2.delta')

path = os.path.join('tmp_path, delta_test2.delta')
should be
path = os.path.join(tmp_path, 'delta_test2.delta')
and
path = os.path.join(tmp_path, 'delta_test3.delta')

so that the delta_test?.delta leaf directories are under the provided tmp_path.

@seperman
Copy link
Owner

Thanks for reporting the typo @emonsler !
I will fix it asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants