Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.12 CI/build workaround #451

Merged
merged 3 commits into from
Feb 26, 2024
Merged

python 3.12 CI/build workaround #451

merged 3 commits into from
Feb 26, 2024

Conversation

leoslf
Copy link
Contributor

@leoslf leoslf commented Feb 21, 2024

Hi @seperman,

Thank you for creating this wonderful tool. I came across trying to upgrade my project which uses deepdiff to python 3.12, and saw the error for python 3.12 on #449.

This PR attempts to fix the python 3.12 build.

Summary:

  • conditionally upgrading setuptools for python 3.12 build before installing dependencies in requirements-dev.txt
  • loosen version constraint of numpy in requirements-dev.txt to make the pip install step go through, as we are installing numpy 2.0.0-dev afterwards anyway

Thank you for your consideration, looking forward for version 6.7.2. Feel free to let me know if there's anything you would like to change.

Best Regards,
Leo

References:
pypa/setuptools#3661 (comment)

@seperman
Copy link
Owner

Awesome. Thanks @leoslf !

@seperman seperman merged commit 87c9129 into seperman:dev Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants