Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delta constructor fix for flat_dict_list param (pull request back to dev branch) #458

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

sf-tcalhoun
Copy link
Contributor

Added fix and unit test for (bug) issue 457, Issue 457

Scenario:
We found that when a flat_dict_list was provided as a constructor
parameter for instantiating a new delta, the provided flat_dict_list
is unexpectedly being mutated/changed, which can be troublesome for the
caller if they were expecting the flat_dict_list to be used BY COPY
rather than BY REFERENCE.

Intent:
Preserve the original value of the flat_dict_list variable within the
calling module/function after instantiating the new delta.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.45%. Comparing base (71fde30) to head (a9bfc08).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #458   +/-   ##
=======================================
  Coverage   97.44%   97.45%           
=======================================
  Files          14       14           
  Lines        3647     3648    +1     
=======================================
+ Hits         3554     3555    +1     
  Misses         93       93           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@seperman seperman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seperman seperman merged commit 32e62bf into seperman:dev Mar 26, 2024
8 checks passed
@seperman
Copy link
Owner

Thank you for contributing @sf-tcalhoun
I will keep you posted when it is released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants