Delta constructor fix for flat_dict_list param (pull request back to dev branch) #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #458 +/- ##
=======================================
Coverage 97.44% 97.45%
=======================================
Files 14 14
Lines 3647 3648 +1
=======================================
+ Hits 3554 3555 +1
Misses 93 93 ☔ View full report in Codecov by Sentry. |
|
Thank you for contributing @sf-tcalhoun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fix and unit test for (bug) issue 457, Issue 457
Scenario:
We found that when a flat_dict_list was provided as a constructor
parameter for instantiating a new delta, the provided flat_dict_list
is unexpectedly being mutated/changed, which can be troublesome for the
caller if they were expecting the flat_dict_list to be used BY COPY
rather than BY REFERENCE.
Intent:
Preserve the original value of the flat_dict_list variable within the
calling module/function after instantiating the new delta.