-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix _dict_from_slots, solves Path comparison #480
Conversation
@artemisart Thanks for making a PR! |
@seperman fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #480 +/- ##
==========================================
- Coverage 96.70% 96.55% -0.16%
==========================================
Files 14 14
Lines 3946 3946
==========================================
- Hits 3816 3810 -6
- Misses 130 136 +6 ☔ View full report in Codecov by Sentry. |
@artemisart We iterate through slot values to compare objects. Before your fix, we would have not processed the Bad() object. Now we process them. Not a super useful test after your fix, I agree. |
Note: you can close #231 |
Hello, I figured out some
__slots__
could be not set which makes getattr fails and soDeepDiff._dict_from_slots
fails, which is what makes Path comparison impossible currently:I fixed this with a hasattr in
_dict_from_slots
.Impact:
Solves #231