Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeepHash: check numpy booleans like native booleans #496

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

doronbehar
Copy link

Fixes #494

@seperman
Copy link
Owner

Awesome! Can you please add a test case for it too?

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.65%. Comparing base (6d8a4c7) to head (cee3d41).
Report is 14 commits behind head on dev.

Files with missing lines Patch % Lines
deepdiff/deephash.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #496      +/-   ##
==========================================
- Coverage   96.70%   96.65%   -0.05%     
==========================================
  Files          14       14              
  Lines        3946     3951       +5     
==========================================
+ Hits         3816     3819       +3     
- Misses        130      132       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@doronbehar
Copy link
Author

OK I tried something. Let's see how CI behaves.

@seperman seperman changed the base branch from master to dev October 25, 2024 17:40
Copy link
Owner

@seperman seperman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seperman seperman merged commit 5d30b3a into seperman:dev Oct 25, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use np.dtype='bool' at all?
2 participants