Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colored Bookmarks #1866

Closed
wladimirleite opened this issue Sep 6, 2023 · 1 comment · Fixed by #1887
Closed

Colored Bookmarks #1866

wladimirleite opened this issue Sep 6, 2023 · 1 comment · Fixed by #1887
Assignees

Comments

@wladimirleite
Copy link
Member

This is an old idea, and I finally decided to give it a try.
Basically it would allow associating a color to each bookmark (at first automatically, then the user could change it).
Although this is a cosmetic enhancement, I believe it may be interesting, as it would:

  • Visually highlight bookmark information;
  • Use a common way to represent bookmarks/labels, used by several well known platforms (e.g. Gmail, GitHub);
  • Show if an "related" item (in Duplicates, Parent, Subitems, Referencing, Referenced By tables) is added to bookmarks, without using too much space as textual column;
  • Show in the gallery if the item is assigned to bookmarks. This is especially useful when going through a lot of images/videos in the gallery tab and using shortcut keys to add items to (or to remove from) bookmarks. Sometimes I am not sure if I actually added/removed items;
  • Show that an item belongs to more than one bookmark in the main items table, even if the bookmark column width is not large enough to fit all titles.

As most GUI changes, preferences are very personal.
@lfcnassif, I will try to finish the code changes and create a PR, so you (and/or maybe somebody else) can take a look to see if the proposed changes make "visual sense", and possibly to suggest points to be reviewed or improved.

@lfcnassif
Copy link
Member

lfcnassif commented Sep 6, 2023

Hi @tc-wleite! I think this can be very useful, especially thinking about your third and forth points. Actually I think I implemented a draft for this years ago (or maybe just used bold fonts for items not viewed yet) just for the main table, but table rendering became slower. Since that time I didn't think about all your points, I simply discarded the idea (not even a draft actually).

wladimirleite added a commit that referenced this issue Sep 10, 2023
@lfcnassif lfcnassif linked a pull request Sep 18, 2023 that will close this issue
patrickdalla added a commit that referenced this issue Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants