Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discord Parser showing wrong attachment file #1898

Closed
felipecampanini opened this issue Sep 26, 2023 · 6 comments
Closed

Discord Parser showing wrong attachment file #1898

felipecampanini opened this issue Sep 26, 2023 · 6 comments
Assignees
@felipecampanini @lfcnassif
Labels
bug

Comments

@felipecampanini
Copy link
Contributor

If there are two files with the same name, the parser could show the wrong file.

The bug was fixed in commit 902326d.

Now the file is fetched based on the name and id contained in the URL.
@lfcnassif
Copy link
Member

lfcnassif commented Sep 26, 2023 •
edited
Loading

Hi @felipecampanini, thanks for reporting. Does this affect any released version? Or just PR #1859?

@lfcnassif lfcnassif added the bug label Sep 26, 2023
@felipecampanini
Copy link
Contributor Author

Hi @lfcnassif, this affects all previously released versions.

@lfcnassif
Copy link
Member

Fine! So, if we release a 4.1.5 version, I'll cherry pick the fix, thank you!

@lfcnassif
Copy link
Member

lfcnassif commented Sep 27, 2023 •
edited
Loading

The bug was fixed in commit 902326d.

Hi @felipecampanini. That commit seems to me to allow a possible ArrayIndexOutOfBoundsException, possibly when handling corrupted data. Could you complement it to check for the array length returned by the split call?

lfcnassif added a commit to felipecampanini/IPED that referenced this issue Sep 28, 2023
@lfcnassif
'sepinf-inc#1898: avoid possible AIOOBE in commit 902326d
bc701bd
lfcnassif added a commit that referenced this issue Sep 28, 2023
@lfcnassif
'#1898: avoid possible AIOOBE in commit 902326d
d71c6c8
@lfcnassif
Copy link
Member

lfcnassif commented Sep 28, 2023 •
edited
Loading

I had some spare time and did it. Fixed on master by commits c5fae0d and d71c6c8.

@lfcnassif lfcnassif changed the title Discord Parser showing wrong file Discord Parser showing wrong attachment file Oct 4, 2023
lfcnassif added a commit that referenced this issue Oct 4, 2023
@lfcnassif
'#1898: avoid possible AIOOBE in commit 902326d
146459c
lfcnassif added a commit to felipecampanini/IPED that referenced this issue Oct 31, 2023
@lfcnassif
'sepinf-inc#1898: avoid possible AIOOBE in commit 902326d
4bb58db
lfcnassif added a commit to felipecampanini/IPED that referenced this issue Oct 31, 2023
@lfcnassif
'sepinf-inc#1898: avoid possible AIOOBE in commit 902326d
52d9b07
@felipecampanini
Copy link
Contributor Author

Sorry for the delay, thanks @lfcnassif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipecampanini felipecampanini

@lfcnassif lfcnassif

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@felipecampanini @lfcnassif