Item with no bookmarks are not filtered properly after deleting a bookmark (master only)

[wladimirleite]

Detected while working on a real case. It seems a critical issue, as I almost missed important items because of it.
I was able to reproduce in a small test case with the following steps.

1. Process a folder with 10 images.
2. Create a bookmark "A" with 5 of them.
3. Create a bookmark "B" with the other 5.
4. Delete bookmark "B".
5. Select "No bookmarks" filter. It should list 5 items (that were previously in bookmark "B"), but non images are shown.

After reopening the case it works.
It may be related to #2251.

After step 3:

After step 4:

After step 5:

[lfcnassif]

@patrickdalla, maybe this regression was caused by the bookmarks refactoring to use RoaringBitmaps, could you take a look?

[patrickdalla]

ok Em seg., 26 de ago. de 2024, 09:12, Luis Filipe Nassif < ***@***.***> escreveu:

…

@patrickdalla <https://github.com/patrickdalla>, maybe this regression was caused by the bookmarks refactoring to use RoaringBitmaps, could you take a look? — Reply to this email directly, view it on GitHub <#2311 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG247SY2FDYCFB7BK3IQQTTZTMSSXAVCNFSM6AAAAABND6QOCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJQGE4DIMBQGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[patrickdalla]

The problem was with internal union bitmap cache that wasn't being invalidate (and updated) after the deletion.
@wladimirleite , check if comit in PR 2312 (brach BookmarkCacheInvalidation) to check if the issue was solved.

[wladimirleite]

Just tested it, and the issue is gone.
Thanks @patrickdalla!