Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New column with item's processing time in a task (#1904) #1907

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

wladimirleite
Copy link
Member

Closes #1904.

@lfcnassif
Copy link
Member

Thank you @tc-wleite! Wouldn't it be better to use evidence ID or evidence object instance itself instead of its path to check if the evidence changed?

@wladimirleite
Copy link
Member Author

Thank you @tc-wleite! Wouldn't it be better to use evidence ID or evidence object instance itself instead of its path to check if the evidence changed?

Yes, I will make this change.

@wladimirleite
Copy link
Member Author

I changed to use the item ID, concatenated with the task name.
It would like to avoid holding any references to these objects.

@lfcnassif
Copy link
Member

A while ago I realized this may not work so well with CarverTask because it pauses processing the parent item and process carved items immediately in the same Worker, so the new stat of parent items would be reset several times. Not sure if it is a real problem since the goal is to detect long frozen times executing the exact same job. What do you think @tc-wleite?

@wladimirleite
Copy link
Member Author

A while ago I realized this may not work so well with CarverTask because it pauses processing the parent item and process carved items immediately in the same Worker, so the new stat of parent items would be reset several times. Not sure if it is a real problem since the goal is to detect long frozen times executing the exact same job. What do you think @tc-wleite?

The idea was to present some information about how long a task is running for a given item, without adding any control overhead or modifications in tasks' code.
In the case you mentioned, the column would show how long it is running the carver task since it switched back to the parent item, not the total time, which seems fine to me.

@lfcnassif
Copy link
Member

In the case you mentioned, the column would show how long it is running the carver task since it switched back to the parent item, not the total time, which seems fine to me.

Agreed, seems fine to me too given the goal!

without adding any control overhead or modifications in tasks' code.

I noticed this implementation approach (just local changes) and liked it very much! Thank you @tc-wleite!

@lfcnassif lfcnassif merged commit 28c8940 into master Oct 11, 2023
2 checks passed
@lfcnassif lfcnassif deleted the #1904_TimeInATaskGUI branch October 11, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New column with item's processing time in a task (processing GUI)
2 participants