Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match the first line of the whole error message to support NodeJS 12+ #122

Merged
merged 1 commit into from
Nov 3, 2019
Merged

Match the first line of the whole error message to support NodeJS 12+ #122

merged 1 commit into from
Nov 3, 2019

Conversation

DanielRuf
Copy link
Contributor

This PR fixes the failing tests on NodeJS 12, also see nodejs/node#26588

Checklist
  • npm test passes and has 100% coverage
  • README.md is updated

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9f0eedd on DanielRuf:tests/fix-nodejs-12-stacktrace-check into 82eacc2 on seppevs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9f0eedd on DanielRuf:tests/fix-nodejs-12-stacktrace-check into 82eacc2 on seppevs:master.

@seppevs seppevs merged commit f44c060 into seppevs:master Nov 3, 2019
@seppevs
Copy link
Owner

seppevs commented Nov 3, 2019

Thank you for your fix!

@DanielRuf DanielRuf deleted the tests/fix-nodejs-12-stacktrace-check branch November 3, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants