This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
Add member reflection info to push constants #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push constant blocks currently do not get member information in the reflection output:
results in
With this PR, it gets the same member information as uniform buffers:
Currently this only applies to json, I wasn't sure push constant info is even written to the binary output, and didn't want to modify it.
Anyway, I'm pretty new to this stuff, so let me know if my assumptions here are wrong, and this is not actually information that should be in the reflection info.